We examined the relation between dietary fruit and vegetables, carotenoids and vitamin intakes and the risk of bladder cancer among male smokers in a prospective cohort study. Over a median of 11 years, we followed 27 111 male smokers aged 50-69 years who were initially enrolled in the Alpha-Tocopherol Beta-Carotene Cancer Prevention Study. During this period, 344 men developed bladder cancer. All of these men had completed a 276-food item dietary questionnaire at baseline. Cox proportional hazards models were used to estimate the relative risks and 95% confidence intervals and to simultaneously adjust for age, smoking history, energy intake and intervention group. Consumption of fruits and vegetables was not associated with the risk of bladder cancer (relative risk=1.28; 95% confidence intervals CI: 0.89-1.84, for highest vs lowest quintile). Similarly, no associations were observed for groups of fruits or vegetables (berries and cruciferous vegetables), or for specific fruits and vegetables. Dietary intakes of alpha-carotene, beta-carotene, lycopene, lutein/zeaxanthin, beta-cryptoxanthin, vitamins A, E, and C, and folate were not related to the risk of bladder cancer. These findings suggest that fruit and vegetable intakes are not likely to be associated with bladder cancer risk. However, these results may not be generalisable to non-smokers.