Non-small cell lung cancer (NSCLC) accounts for approximately 80-85% of all lung cancer cases. Cigarette smoking is the number one risk factor which is attributed to more than four out of five cases of lung cancers. The prognostic impact of cell cycle regulation-associated tumor suppressors including p53 and p21 for NSCLC is still controversial. In the present study, we examined p53 and p21 expression using immunoblotting in tumor and adjacent non-cancerous tissues from NSCLC patients. Moreover, tissue microarrays (TMAs) including 150 specimens was used to examine p53 and p21 expression by immunohistochemical staining (IHC). The association between p53/p21 and various clinicopathological characteristics was evaluated. Kaplan-Meier overall survival was used to analyze the association between p53/p21 expression and prognosis of NSCLC patients, as well as the association of cigarette smoking with p53/p21 expression and prognosis. The results of the immunoblotting showed that expression of p53 and p21 in tumor tissues was significantly higher than that in the matched adjacent non-cancerous tissues (P<0.001 and P<0.05, respectively). The IHC results showed that 50.67% of the cases had high expression of p21; however, the percentage of patients having high expression of p53 was 31.3%. Univariate and Cox regression models were used to evaluate the factors related to prognosis with p53 and p21 expression. Multivariate analysis indicated that p53 expression was an independent prognostic factor for NSCLC (P=0.005), while p21 could not serve as an independent prognostic factor (P=0.123). In addition, smoking history was closely related to lung cancer risk (P=0.041), but could not be an independent assessment factor (P=0.740). In this study, we further demonstrated the association of p53/p21 expression and cigarette smoking. Our results suggest that cigarette smoking and overexpression of p53 or p21 are associated with poor prognosis. The combination of p53/p21 expression and smoking history may be a useful biomarker for tumor progression and prognosis of NSCLC patients.